Repository navigation
Conversation
|
Hi, I also think that we should not interfere with angular's dependencies. I think it makes more sense to update angular itself, even if this requires more work. |
|
I agree with @Reamer on that updating Angular itself. Otherwise we'll need to take care of this single version update all throughout |
|
Thank you @Reamer and @JooHyukKim for the feedback. I appreciate the clarification on keeping I’ll start looking into what’s involved in updating Angular itself, as you suggested, and see how it goes. Thank you again. |
|
Hello @Reamer and @JooHyukKim (and the rest of the team,) Thank you again for your feedback on this PR. After looking into updating Angular, I’ve realized that it involves more work and checks than I initially expected. Given that this update will take some time and careful consideration, I believe it’s best to close this PR for now. I’m looking forward to finding other areas where I can be more helpful. |
### What is this PR for? The lockfiles of both web UIs (`zeppelin-web-angular` and `zeppelin-web`) resolve `websocket-driver` to 0.7.4, which is affected by [CVE-2026-54466 / GHSA-xv26-6w52-cph6](GHSA-xv26-6w52-cph6): the draft-75/76 frame parser accumulates the length header into an unbounded integer, so a client sending an indefinite sequence of continuation bytes (`0x80` or above) causes precision loss and mis-framing of subsequent payload data. The fix is in 0.7.5 (latest release), which closes the connection as soon as the accumulated length exceeds the configured max length. `websocket-driver` is a dev-only transitive dependency (`<at>angular-devkit/build-angular` → `webpack-dev-server` → `sockjs` → `faye-websocket`), so shipped Zeppelin artifacts are not affected — but the vulnerable version keeps being flagged by dependency scanners. Since `faye-websocket`'s constraint is `>=0.5.1` and `sockjs`'s is `^0.7.4`, this is a lockfile-only bump: each `package-lock.json` changes only the resolved `websocket-driver` entry (version / resolved / integrity). 0.7.4 and 0.7.5 declare identical dependencies, so no other entry changes. Note: the dependabot security-update group PR #5354 covers `shell-quote` in the same directory but did not pick up `websocket-driver` (advisory published 2026-07-15, before that PR was created), presumably because it sits four levels deep in the dependency tree — hence this manual bump. The earlier bump attempt in #4798 (ZEPPELIN-6061, for a deprecation warning) was closed pending an Angular upgrade; master is on Angular 21 now, and this change does not touch `package.json` at all. ### What type of PR is it? Improvement ### Todos * [x] - Bump the `websocket-driver` lockfile entry to 0.7.5 in `zeppelin-web-angular/package-lock.json` and `zeppelin-web/package-lock.json` ### What is the Jira issue? * https://issues.apache.org/jira/browse/ZEPPELIN-6590 ### How should this be tested? * `cd zeppelin-web-angular && npm ci` — installs cleanly and resolves `websocket-driver<at>0.7.5` (verified locally; `npm ls websocket-driver` shows a single 0.7.5 instance) * CI web build should pass unchanged — dev-server behavior is unaffected (0.7.5 only adds a max-length guard in frame parsing) ### Screenshots (if appropriate) ### Questions: * Does the license files need to update? No * Is there breaking changes for older versions? No * Does this needs documentation? No Closes #5369 from dev-donghwan/ZEPPELIN-6590. Signed-off-by: ChanHo Lee <chanholee@apache.org>
What is this PR for?
This PR addresses a deprecation warning that was encountered when running the Zeppelin frontend using 'npm start'.
The warning was caused by the websocket-driver package, which was using the deprecated process.binding('http_parser') API. The websocket-driver package has been installed to a newer version that removes the deprecated API usage, resolving the warning.
What type of PR is it?
Improvement
Todos
What is the Jira issue?
ZEPPELIN-6061
How should this be tested?
Screenshots (if appropriate)
Before

After

Questions: